-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Portal): allow links in property table types and correct link font size #4488
Conversation
snorrekim
commented
Jan 22, 2025
•
edited
Loading
edited
- Make link in inline-code have same font-size
- Make it possible to use link markdown in types
- Other: create a structure that makes it easy to have different styling for primitive types in the future
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
62c35e5
to
780fafe
Compare
I updated the screenshot above with |
53bc17b
to
0dbd946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
The pull request title, chore(Portal): allow links in types and make primitive types purple
doesn't seem to align with a statement in the PR description Make non-primitive types purple
. Should primitive or non-primitive types be purple? 🤔
Consider updating either description or title 🙏
In the code, I see const colorPrimitive = 'var(--color-success-green)'
so primitive types is green and not purple, right? 💭
Right, the title is wrong, I'll fix it. Primitive types should be green. I'm also going to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the property name plays a much more important role during the process of scanning and consuming the documentation. However, the use of colors can be distracting and take away from effectively focusing on the content.
I think we should evaluate other ways to communicate primitives, if it is important to distinguish them.
fa91f36
to
f7cff43
Compare
Changed the primitives color back to green for now to finish the PR. The option is still there for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👏 Thank you for this 🎉
🎉 This PR is included in version 10.63.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |