chore: update path in dnb-skeleton-theme-sbanken.scss #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
commented
Jan 30, 2025
| @@ -2,6 +2,6 @@ | |||
| * No theme is provided | |||
| * | |||
| * Theming variables for the Skeleton component is required globally | |||
| * and is thus defined in src/style/themes/theme-sbanken/customisations.scss | |||
There was a problem hiding this comment.
This path is not existing, what is the correct path?
There was a problem hiding this comment.
In the globals.scss file there is --skeleton-color and --skeleton-color--contrast.
There was a problem hiding this comment.
But these could actually be moved into the empty theme files instead. Would work just fine. Probably because of the new setup we got with Sbanken.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.