[BLOOM-009] 예외 응답 처리 리팩토링 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Dompoo
commented
Jul 24, 2024
Dompoo
commented
- HttpStatus와 message를 담는 ErrorType 생성
- ErrorResponse와 커스텀 예외가 ErrorType을 참조하도록 수정
- 기존 커스텀 예외들을 이에 맞게 수정
- 반복되는 코드가 확실히 줄었습니다.
- 예외와 예외 응답의 결합이 느슨해져, 추후 로깅과 응답을 가공할 때 편할 것 같습니다.
Closed
stophwan
reviewed
Jul 24, 2024
| @@ -1,5 +1,5 @@ | |||
| <!-- 제목은 아래처럼 --> | |||
| <!-- [#이슈번호] PR 제목 --> | |||
| <!-- [BLOOM-001] PR 제목 --> | |||
Comment on lines
8
to
16
| class GlobalExceptionHandler { | ||
| @ExceptionHandler(MyException::class) | ||
| fun handleMyException(exception: MyException): ResponseEntity<ErrorResponse> { | ||
| val errorType = exception.errorType | ||
| return ResponseEntity | ||
| .status(exception.status) | ||
| .body(ErrorResponse.from(exception)) | ||
| .status(errorType.status) | ||
| .body(ErrorResponse.from(errorType)) | ||
| } | ||
| } |
There was a problem hiding this comment.
RestControllerAdvice에서 log도 출력을 해야하는데 ErrorType에 Log 레벨을 추가하는게 좋을 것 같아요~
여기서는 when으로 분기처리하고요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.