Cookieconsent #100
Cookieconsent #100
Conversation
…new tab in Site Settings/Site Behavior
|
|
| @@ -28,8 +28,5 @@ namespace Dnn.PersonaBar.SiteSettings.Services.Dto | |||
| { | |||
| public class UpdateOtherSettingsRequest | |||
There was a problem hiding this comment.
Should this class be removed completely?
There was a problem hiding this comment.
I hesitated. Because we may (within the next few weeks) discover settings that should find their way here. Can we continue with this PR and decide this in the run-up to the 9.3 release?
| </data> | ||
| <data name="plDisplayCopyright.Text" xml:space="preserve"> | ||
| <value>Display Copyright</value> | ||
| </data> |
There was a problem hiding this comment.
Should we create a needs translation label? Do we need to get this translated prior to v9.3? If so, what languages are required?
There was a problem hiding this comment.
True. IMHO it's not critical but it needs translation.
There was a problem hiding this comment.
IMHO, translations should be open sourced.
| @@ -1072,7 +1072,7 @@ | |||
| <value>Enable Localized Content</value> | |||
| </data> | |||
| <data name="EnableLocalizedContentHelpText.Text" xml:space="preserve"> | |||
| <value>Enabling localized content allows you to provide translated module content in addition to displaying translated static text. Once localized contetnt is enabled the default site culture will be permanently set and <strong>cannot be changed</strong>.</value> | |||
| <value /> | |||
There was a problem hiding this comment.
It looks like this content was removed inadvertently?
There was a problem hiding this comment.
Yes. This should be reverted.
|
Closing, was included as part of #136 |
CONTENT-7612: localize dnn-file-upload component.
This implements the settings management for cookie consent and groups privace settings on one tab.
dnnsoftware/Dnn.Platform#2361
#99
Bonus: it brings back the "display copyright" setting as well.