This repository has been archived by the owner on Oct 6, 2019. It is now read-only.
Blank_Name_is_accepted_as_Group_name #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
valadas
approved these changes
Aug 8, 2019
bdukes
approved these changes
Aug 9, 2019
|
@SergeyDryomin this is currently targetting development which means it would be included in Dnn 10, would you like to re-target the release/3.0.x branch for inclusion in Dnn 9.4.1 ? |
7 tasks
SergeyDryomin
deleted the
bugfix/DNN-18333_Blank_Name_is_accepted_as_Group_name
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "Blank name is accepted as Group name"
Added validation for white spaces string, when new group added.
*No UT added - to add it have to add UT new project
Summary
dnnsoftware/Dnn.Platform#2927
DNN-18333
Note: same issues possible to fix into 'DNN Platform\Library\Common\Requires.cs' (with adding new method or just to change NotNullOrEmpty to IsNullOrWhiteSpace validation)