This repository has been archived by the owner on Oct 6, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Restructure AE Extensions into a single VS Project. #693
Merged
mitchelsellers
merged 66 commits into
dnnsoftware:development
from
nbrane:devops/simplify-projects-round1
Apr 19, 2019
Merged
Restructure AE Extensions into a single VS Project. #693
mitchelsellers
merged 66 commits into
dnnsoftware:development
from
nbrane:devops/simplify-projects-round1
Apr 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify-projects-round1
… the users test project
donker
approved these changes
Apr 17, 2019
daguiler
approved these changes
Apr 17, 2019
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Notes to @dnnsoftware/tag when we merge this one in, avoid using the "Squash & Merge" so we can keep the history on the individual commits for historical purposes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently this combines the all of the persona bar extensions into a new common project called
Dnn.PersonaBar.Extensions
. This reduces the projects in the solution toThe goal for this phase is to end up with 3 DNN install files. Dnn.EditBar, Dnn.PersonaBar, and Dnn.PersonaBar.Extensions. Yarn workspaces will also be configured in the Dnn.PersonaBar.Extensions project to further improve our build times and developer productivity.
Testing Summary
Completed install with
v9.3.1.2
and AE v3.0.0.8. Before triggering the install, I deleted the23
PersonaBar Extensions from ~/install/module and replaced them with the21
fromv3.0.0.8
. No issues found.Completed install with
v9.4.0.alpha-18
and [AE v3.0.0.10] Before triggering the install, I deleted the23
PersonaBar Extensions from ~/install/module and replaced them with the3
fromv3.0.0.10
. Users module not rendering due to missing export sub-bundle. Retesting with v3.0.0.14 and no issues detected.Build Time Improvements
Full CI (clone, compile, yarn install/build, package, unit test)
*v2.0.0: 17min 30s
*v3.0.0: 11min 30s
Reduction of Packages to Install/Upgrade
This reduces the packages installed and upgraded on platform releases by 50% (v9.3.2 has 41 modules to install, v9.4.0 has 21).
Testing not yet completed.
Upgrade from
v9.3.1
, andv9.2.2
to verify uninstallation of all old extensions and everything still functions under the new v3 package.Areas for Future Improvements
PersonaBar.UI
also contains a react.web project. This would benefit if it's loaded into the yarn workspaces configuration. The initial idea is to move the config for yarn workspaces up to the root. If that doesn't work, we will need to relocatePersonaBar.UI
below theWebApps
folder. The same issue will apply afterReact.Common
is merged into the AE repo.Combine the UI and Library projects into a single project/assembly.
EditBar.UI
andEditBar.Library
would becomeEditBar
.PersonaBar.UI
andPersonaBar.Library
would becomePersonaBar
. This could potentially be a breaking change as any personabar extensions would need to be updated for the new reference.