Merge pull request #4773 from berkarslan-xo/bugfix/Issue-4772

Issue-4772 - Wrong PortalId is getting set when there are multiple sites existing
dnnsoftware · Aug 3, 2021 · db2c94f · db2c94f
2 parents 1477ee0 + 1e99776
commit db2c94f
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 2 deletions.
diff --git a/Dnn.AdminExperience/ClientSide/SiteSettings.Web/package.json b/Dnn.AdminExperience/ClientSide/SiteSettings.Web/package.json
@@ -4,6 +4,8 @@
   "private": true,
   "scripts": {
     "build": "set NODE_ENV=production&&webpack -p",
+    "test": "jest",
+    "test:watch": "jest --watch",
     "debug": "set NODE_ENV=debug&&webpack -p",
     "webpack": "webpack-dev-server -d --port 8085 --hot --inline --content-base dist/ --history-api-fallback",
     "watch": "set NODE_ENV=debug & webpack --mode=development --progress --colors --watch",
@@ -25,9 +27,11 @@
     "css-loader": "2.1.1",
     "eslint": "5.8.0",
     "eslint-loader": "4.0.2",
+    "eslint-plugin-jest": "^22.0.0",
     "eslint-plugin-react": "7.11.1",
     "eslint-plugin-spellcheck": "0.0.11",
     "file-loader": "3.0.1",
+    "jest": "^24.8.0",
     "jwt-decode": "2.2.0",
     "less": "3.9.0",
     "less-loader": "5.0.0",

diff --git a/...dminExperience/ClientSide/SiteSettings.Web/src/reducers/__tests__/siteInfoReducer.test.js b/...dminExperience/ClientSide/SiteSettings.Web/src/reducers/__tests__/siteInfoReducer.test.js
@@ -0,0 +1,29 @@
+import siteInfo from "../siteInfoReducer";
+import { siteInfo as ActionTypes } from "../../constants/actionTypes";
+
+describe("Site Info Reducer", () => {
+    it("Sets the current portal id correctly when there are multiple sites", () => {
+        // Arrange
+        let action = {
+            type: ActionTypes.RETRIEVED_PORTALS,
+            data: {
+                portals: [
+                    {
+                        PortalID: 0,
+                        IsCurrentPortal: false
+                    },
+                    {
+                        PortalID: 1,
+                        IsCurrentPortal: true
+                    }
+                ]
+            }
+        };
+
+        // Act
+        let state = siteInfo({}, action);
+
+        // Assert
+        expect(state.portalId).toEqual(1);
+    });
+});
diff --git a/Dnn.AdminExperience/ClientSide/SiteSettings.Web/src/reducers/siteInfoReducer.js b/Dnn.AdminExperience/ClientSide/SiteSettings.Web/src/reducers/siteInfoReducer.js
@@ -26,11 +26,13 @@ export default function siteInfo(state = {
             return { ...state,
                 clientModified: action.data.clientModified
             };
-        case ActionTypes.RETRIEVED_PORTALS:
+        case ActionTypes.RETRIEVED_PORTALS: {
+            let currentPortal = action.data.portals.find(a => a.IsCurrentPortal === true);
             return { ...state,
                 portals: action.data.portals,
-                portalId: action.data.portals[0].PortalID
+                portalId: currentPortal != null ? currentPortal.PortalID : action.data.portals[0].PortalID
             };
+        }
         default:
             return state;
     }