dnn.js not included on the page when cookie consent is enabled

[Mitjan11]

Description of bug

The new cookie consent functionality released with DNN 9.3.1 depends on the window.dnn object being available which is created by dnn.js. However, when not using a skinobject that includes dnn.js on the page (or manually registering it), dnn.js is not included on the page and the cookie consent functionality breaks.

Relevant code:

$(window).on('load', function () {
    window.cookieconsentoptions = window.cookieconsentoptions || {};
    window.cookieconsentoptions.content = {
        message: window.dnn.getVar('cc_message'),
        dismiss: window.dnn.getVar('cc_dismiss'),
        link: window.dnn.getVar('cc_link')
    }
    if (window.dnn.getVar('cc_morelink') != '') {
        window.cookieconsentoptions.content.href = window.dnn.getVar('cc_morelink')
    }
	if (!window.cookieconsentoptions.palette) {
		window.cookieconsentoptions.palette = {
			"popup": {
      "background": "#000"
    },
    "button": {
      "background": "#f1d600"
    }
		}
	}
    window.cookieconsent.initialise(window.cookieconsentoptions);
});    

Our current short-term (as in, critical fix) workaround involves including the search skinobject on the page in a hidden div. Less than ideal of course.

Steps to reproduce

List the steps to reproduce the behavior:

1. Create a simple empty page skin (no skinobjects that register dnn.js)
2. Enable the cookie consent functionality
3. Log out (dnn.js is loaded when logged in, into a SuperUser account anyway)
4. Cookie consent message does not show

Current result

The cookie consent popup does not show.

Expected result

The cookie consent popup should show.

Screenshots

If applicable, provide screenshots to help explain your problem.

Error log

See above

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

• 9.3.1
• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

[Tychodewaard]

This is in 9.3.2 as well.

[Tychodewaard]

@Mitjan11 Do you know of another workaround? Because on of the sites is using SearchBoost, so, the skinobject has already been replaced...
Should I register something like:
<dnn:DnnJsInclude runat="server" FilePath="js/dnn.js" ForceProvider="DnnFormBottomProvider" Priority="130" PathNameAlias="SkinPath" /> ?

[valadas]

@Tychodewaard I think you proposed workaround should work, I have not tried it though, but we need to fix this bug and have thecookie consent feature request that file to be included for sure.

[yog-it]

I had the same issue and your workaround fixes the issue by placing that line in the skin's .ascx file and removing PathNameAlias="SkinPath".

[valadas]

Can no longer reproduce in 9.6.2 and I remember there was a PR merged about this.

[trouble2]

This is DNN 9.9.0

[valadas]

I reopened the issue but I did not test this out, does it happen to you on a simple clean install just by enabling cookie consent or is there more steps to make it happen ?

[trouble2]

Yes, this is a clean DNN 9.9.0 with cookie consent enabled.
This site has got it's own skin, so perhaps xcillion by default includes the dnn.js I don't know...
We've used the workaround for now, but perhaps, when including the cookie consent it should also trigger the inclusion of dnn.js or include some code by itself to deal with the situation

[valadas]

Ok, thanks, I thought I had seen a PR to specifically fix this, guessed I dreamed about that. The issue is reopened. @donker does that ring a bell about being already fixed in a PR or am I just crazy?

[Tychodewaard]

@valadas I think you were thinking of #4762

[valadas]

So it's resolved right ?

[bdukes]

Yes, in 9.10.1