Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where dnn.js was not requested for cookie consent #4763

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 28, 2021

Fixes #4762

Verified

This commit was signed with the committer’s verified signature.
bdukes Brian Dukes
@bdukes bdukes added this to the 9.10.1 milestone Jul 28, 2021
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🙌🏼

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@valadas valadas merged commit ecb356d into dnnsoftware:develop Jul 29, 2021
@valadas valadas changed the title Ensure dnn.js is requested for cookie consent Fixed an issue where dnn.js was not requested for cookie consent Aug 13, 2021
@bdukes bdukes linked an issue Sep 2, 2021 that may be closed by this pull request
12 tasks
@bdukes bdukes deleted the cookie-consent-dnn-js branch September 20, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie Consent may cause JavaScript error dnn.js not included on the page when cookie consent is enabled
3 participants