Method not found: 'System.String DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, System.String, System.String, DotNetNuke.Entities.Portals.PortalSettings)' #3289
Comments
|
A suggested solution is to revert this in 9.4.3? |
|
Ok, so if I understand correctly, in #3160 the overload was modified to use the IPortalSettings abstraction instead of PortalSettings, but from the comments on there, PortalSettings does Inherit from IPortalSettings already and for that reason this was not expected to be a breaking change. It would be really nice to get some testing from module vendors before/during the RC stages to spot these issues before releases. |
|
@valadas Mariette did reported this issue about 24 hours prior to official release of DNN 9.4.2. Our team confirmed the issue and we were still gathering more information regarding the cause; however, official release was rolled out the same day. Perhaps, we can have designated minimum days after RC before release? |
|
Really? We have been discussing PR #3160 since mid-october including possible breaking changes. The RC has been published on November 5th, the release on November 12th and this issue reported today... Did I miss something? |
|
Perhaps, I'm missing the boat. We don't individually track PR requests or individual issues. We only test our products when RC is released. Considering we have over 60+ products; that's a significant undertaking and takes some resources. I simply suggested that we should have a defined minimum days prior to release so we're aware that if an RC is released on 1st; it will not be officially released until 7th or 15th. Just a suggestion... I'm not stepping on your toe. Issue was originally reported by Mariette on Slack. We were working with her and we did point out to her that this is a DNN issue. DNN 9.4.2 was released while we were investigating. Again, my post here was to suggest to avoid this in future. But if suggestions are not welcome then I'm very sorry. |
|
No, no worries, just trying to figure this out because I did not see that reported before final went out and it was not expected to be a breaking change. That being said it would be nice to have more module vendors follow the progress of the platform and chime in on those types of risks on their end... I think nobody makes breaking changes on purpose and we try to test as much as possible but it has been a couple times that module vendors report issues right after the official release. We had 2-3 weeks RC stages and it happened too... 9.4.0 was in RC stage from July 19th and got out on September 11th and issues with some modules where reported one or two days after the official release... I am not blaming anyone but looking into solutions and I believe the RC period is not the major issue, it is more to get some module vendors to follow on ideas and upcoming changes before they become an issue... |
|
I agree. We can commit to testing for each RC; but we do need a minimum defined RC period. We only had 4 business days between Nov 5th and 12th; it's extremely hard to re-allocate resources to test 60+ products within such a short span. We can discuss this further in our next Tech Advisory meeting. |
@valadas My understanding is that the breaking change is caused due to introduction of IPortalSettings in DotNetNuke.Abstractions.dll |
This is what was in the roadmap though https://dnncommunity.org/road-map it only got 1 day later than planned for both the RC and the release...
Yes it appears this is the cause, reverting the change might be a big thing, maybe we can find a way to have some sort of alias to it or an additional overload deprecated for a future release or some such...
This is the part I did not get, knowing it before the release, for sure would have been a good reason to not publish it yet, but I did not see that issue before the release myself. |
|
This was the first version I was involved in testing and the result shows. I am happy with this though more time to correct major issues like the one we see now is really needed. I had a slow start testing because it was the first time, next time will be better and quicker. |
|
I will try to test these modules on one of my test sites as well to help with these. My beta sites do not have much on it currently because I start them from scratch a lot. I will load up 2sxc for those users and Mandeeps collections. I can't say I will be there for every RC but I will try to help here as they both seem to have been hit by updates. I can be an extra voice when I can. |
|
This would be good to put as Known Issues to help stop others now. |
|
Yeah, test early, test often :) Any testing hands are welcome specially regarding upgrades and third party modules. |
|
@valadas Can you add this to the release notes please? |
|
Sure can |
|
Done |
|
Thank you @valadas |
|
I can confirm also the same errors using Ventrian News Articles. |
|
Maybe we can push out a 9.4.3 RC fix soon with the fix and start a 9.4.4 milestone. I have a PR I would like to see working that is in 9.4.3 and one I will put together today that was my first accepted in 10 but should be in 9 I will redo right now. |
|
We certainly have a better setup now for quick release cycles. Now the thing is how do we resolve this issue? @ahoefling @mitchelsellers opinions? Add an overload marked deprecated for Dnn10? Or do you guys have better ideas to handle this? |
I will add this module as well. Thanks @b-creative @marietteknap for stepping up here with testing efforts for the community... YOUR AWESOME! |
|
I'm working on a PR that will add back the overloads but mark them as deprecated. Still testing that it fixes the issue and doesn't cause compilation issues going forward (e.g. ambiguous overload) |
|
Merged, will be out with 9.4.3 soon... |
* Do not store these portal settings when setting their property on the portalsettings object * Removed DnnHttpControllerActivator and added DependencyResolver implementation using the IServiceProvider * Added xml comments for the new DnnDependencyResolver * Added DnnDependencyResolver Unit Tests * Replaced IServiceProvider mock with full IServiceProvider implementation to work with Web API tests * Added more unit tests for the DnnDependencyResolver to cover GetServices (multiple) and BeginScope * Do not show "No Search results" message when no search is performed. (#3203) * Revision of build process part 1 (#3137) * Move website folder * repairs * Update Cake * Move external task to its own file * Begin packaging scripts in cake * Further work on packaging * Ensure Telerik project also gets new version nr * Move Telerik PDF to its proper place * New logic for packages that are already in final form in the repo and just need to be zipped. * Bring fips Lucene lib back under git control * Newtonsoft package and repair to telerik package * Splitting off other tasks * Upgrade and deploy packages * Symbols package * Get rid of platform ver in manifest * Final fixes - working packages * Move compilation stuff * House cleaning * peg utils version * Fix to ckep script * suppress warnings * Variable initialization issue * Removing unused scripts * Revert change to Telerik package version * Move "other" to "thirdparty" * Get rid of hard coded Newtonsoft version * Max cpu to 4 for compiling * Repairs to MSBuild scripts to get AE to build properly * Correcting paths * Cleaning up * Trying to fix ignore file * Update Build/Cake/thirdparty.json Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Remove absolute path from .gitignore * Fix extension of DNC library package * Merging AE and DNN build scripts * Fixes to scripts * Clean up symbols project for AE since they are included in DNN project now * Add previously untracked Yahoo compressor dlls * Remove version information from SolutionInfo.cs * Fix errors introduced in rebase * Fix incorrect paths * Change build order of MSBuild to build extensions before personabar ui. * Make white-space visible in log viewer (#3198) * DNN-34236: check the url with case insensitive. * DNN-29417 Username is changed to email address in the user profile if the "Use Email Address as Username" is enabled. * Fix to installer and the dependencies of the HTML and DA modules * DNN-24945 - Always redirect to the source portal page after creating (#3223) group * Fix Typo (#3234) * Improve querystring parse (#3242) * Improve props popup * Improve input checking of sites (#3243) * Fixes an upgrade issue that affects 9.4.1 => 9.4.2 upgrades (#3282) * Fixes an issue with a duplication of assembly binding * Removed hardcode version in manifest * Further reorganization of build process (#3236) * Introduce settings and add custom version nr * Ability to create a local dev site * Move node workspaces to root * Reshuffling of variables in MSBuild * Repairs * Fix * Allow local override of global build variables * Only save manifests if the file is not there. This prevents overwriting in case of a failed build before. * Ensure projects build in debug to the website path specified by the platform build settings * Don't track vscode folder * Fixes #3168 Test Sending Email Issues (#3237) * Use Admin Email for Send if smtpHostMode false * Fix Test Email Settings TO and FROM Addresses If I did this right and it should make sense is I set the test email to be able to go to the user testing. After all they are who are trying to make it work. It can be any email used by anyone and usually to see this feature you are a host or portal administrator so security should not be as much of a concern here. The FROM address will use the HOST email settings if set to HOST mode in DNN for the portal, otherwise it should use the Portal Administrators Email account to send from. This however does not address the issue of using the email address supplied in settings and creating another setting which will be applied next to figure out the correct logic. * Update ServerSettingsSmtpAdminController.cs * Fix build issue to previous changes. PortalSettings.UserInfo.Email is this the current user email? I am still getting my things setup. I ran VS 2019 to build successfully and I am trying to read through the namespaces correctly so I can understand the changes. I noticed a number of files possibly needing updates due to being deprecated in 9.4.2 but after I changed the namespace issue those warnings went away. One last thought is how do you get intellisense working on DNN solution. Is that a dream to have or am I missing something in my setup? * Change to address to the current user's email testing the server. I believe a UI to set the TO address would be nice to help troubleshoot and address issues trying to send to a specific user. * Corrected To address for current user email * TO Current User Email * DNN-29110 Site Assets > Select All is not working (#3251) * DNN-29110 Site Assets > Select All is not working * Code review fix * Moves Remember Login above Login Button: referenced in issue #2471 #3255 (#3256) * Move Remember Login Above Login Button * Update Login.ascx * file copy paste issue... * DNN-34250 Search is not working even after re-Indexing Search for All DNN Portals (#3260) * DNN-32474 - Recursive delete option is added (#3249) * Move Country Above Region in UserProfile.cs * spacing issue resolved. * I keep saving but github is moving it on its own. * Fixed tab for spaces to resolve spacing issues * Add PortalSettings overloads back (#3295) Fixes #3289 * Updates issue templates as per 9.4.2 release * Move Email Above Username in User.ascx #3305 (#3306) * Move Email Above Username in User.ascx * Fixed tab index values in User.ascx * Fix NuGet warning NU5048 (#3304) The iconUrl property of the nuspec file is deprecated, it's recommended to add an icon property, which points to a file within the package, while also retaining the iconUrl property for older clients. See https://docs.microsoft.com/en-us/nuget/reference/nuspec#iconurl * Word-Break added to Journal P (#3307) * Set core object versions to core version (#3287) Ensure skin and radeditorprovider get the core version nr and add SPROC to set the version of all core packages/desktopmodules to the core version Fixes #3239 * Third installment of build reorganization (#3285) * Improve versioning * New approach: keep versions in source control and change upon CI build * Remove previous versioning logic * Cleaning up tasks * Fixes * Ensure UpdateDnnManifests targets just the right manifests * Harmonize naming of zips and nuget packages * Testing webpack building to dev website * Adjust webpack projects in AE to build to dev site * Fixes * Delete duplicate stuff * This is generated by Webpack and shouldn't be tracked * Include missing project from Lerna * Fixes for building SitesListView * Update to packages * Further cleaning * Remove RadEditorProvider * Fix ModuleSettings > Added to Pages grid, pager wasn't working * Allow only alphanumeric characters to be used when forming url from website name (#3316) * Ensure UpdateDnnManifests doesn't run for building dev site (#3314) * Reload page when the code tells you to (#3315) * Reload page when the code tells you to * Optimize code * Google Analytics TrackingID is stored in lowercase #3318 (#3322) * Update sums.resources * Fix casing mismatch errors in security analyzer file compare * Update Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Security/Checks/CheckDefaultPage.cs Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Registered IPersonaBarContainer with DI (#3329) * Document approval process and group * Fix typo * Relaxed nuget.cake wildcard (#3331)
Description of bug
9.4.2 has broken all of our modules due to Method not found: 'System.String DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, System.String, System.String, DotNetNuke.Entities.Portals.PortalSettings)'.
Error log
2019-11-13 10:05:23.285+01:00 [WIN-SVOFJIQAQ17][D:8][T:9][FATAL] DotNetNuke.Framework.PageBase - An error has occurred while loading page.
System.MissingMethodException: Method not found: 'System.String DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, System.String, System.String, DotNetNuke.Entities.Portals.PortalSettings)'.
at Mandeeps.DNN.Libraries.URL.Factories.URLFactory.GetFriendlyURL(Nullable
1 ModuleID, PortalSettings pS, String QueryParameters, URLEntity u) at Mandeeps.DNN.Modules.LiveArticles.Components.LiveArticlesController.GetArticleLink(ArticleVersion article, VersionPage vPage) at Mandeeps.DNN.Modules.LiveArticles.Components.LiveArticlesController.ReplaceArticleTokens(ArticleVersion Article, String Template, Int32 UserId, Dictionary2& RenderControlsDefinition, Boolean ThumbnailReplace, Int32 CurrentPageId, Widget wt, Boolean UseStoredProcedure, Boolean IsAjaxPreview)at Mandeeps.DNN.Modules.LiveArticles.Components.LiveArticlesController.RenderRecentArticles(Widget widget, Int32 UserId, Dictionary`2& RenderControlsDefinition)
at Mandeeps.DNN.Modules.LiveArticles.UI.LiveArticlesWidget.View.Initialize()
at System.Web.UI.Control.OnLoad(EventArgs e)
at DotNetNuke.Entities.Modules.PortalModuleBase.OnLoad(EventArgs e)
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
Additional context
See
Dnn.Platform/DNN Platform/Library/Services/Url/FriendlyUrl/FriendlyUrlProvider.cs
Line 50 in 8151da2
Affected version
Affected browser
The text was updated successfully, but these errors were encountered: