Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Messages are not using 100% of screen #3387

Closed
8 tasks
thabaum opened this issue Dec 6, 2019 · 4 comments
Closed
8 tasks

Form Messages are not using 100% of screen #3387

thabaum opened this issue Dec 6, 2019 · 4 comments

Comments

@thabaum
Copy link
Contributor

thabaum commented Dec 6, 2019

Description of bug

form messages can only expand to 980px

Steps to reproduce

List the precise steps to reproduce the bug:

  1. Go to a page that has administrator only form message

Current behavior

for high resolution screens this message is not expanding across the window.

Expected behavior

The message area uses all of the allowed space.

Screenshots

If applicable, provide screenshots to help explain the bug.
image

Error information

Provide any error information (console errors, error logs, etc.) related to this bug.

Additional context

Provide any additional context that may be helpful in understanding and/or resolving the bug.

Affected version

  • 10.0.0 alpha build
  • 9.5.0 alpha build
  • 9.4.3 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer
  • Edge
@bdukes
Copy link
Contributor

bdukes commented Dec 6, 2019

I think this is an intentional design decision to restrict the form messages from growing too large. If you want them to be 100% in your site, you can override the styles via your theme or the site's stylesheet (i.e. portal.css). My opinion would be that this is not a bug/defect and should remain as-is.

@thabaum
Copy link
Contributor Author

thabaum commented Dec 6, 2019

ok no worries just looked odd on the form. Felt like it should use the full screen or space allowed in the skin template instead of cutting itself off.

image

Not a big deal just close if not a desirable outcome here I understand.

@valadas valadas added this to the 9.5.0 milestone Dec 9, 2019
@valadas
Copy link
Contributor

valadas commented Dec 9, 2019

Well, this is certainly an opiniated thing but I think the default of 100% and people can override it if they want is better than a fixed default and people can make it otherwise. 100% is certainly more consistent IMO Very ofter with css frameworks, the forms measure like around 1050px wide with the default 980px it looks like it is just missing a little bit... I marked is as an enhancements and approved the PR but if there is traction to not merge that, please comment...

@valadas
Copy link
Contributor

valadas commented Dec 9, 2019

PR merged

@valadas valadas closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants