Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnnFormMessage 100% width fix #3388

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Conversation

thabaum
Copy link
Contributor

@thabaum thabaum commented Dec 6, 2019

#3387

Summary

allows a form message to use 100% of the area it is presented in.

image

will now look like
image

if accepted as a solution.

@thabaum thabaum changed the title Patch 19 dnn Message Form 100% width fix Dec 6, 2019
@thabaum thabaum changed the title dnn Message Form 100% width fix dnnFormMessage 100% width fix Dec 6, 2019
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@valadas valadas added this to the 9.5.0 milestone Dec 9, 2019
@valadas
Copy link
Contributor

valadas commented Dec 9, 2019

For reviewers, just in case you don't look at the issue linked, this is by design limited to a fixed pixel max-width. It is not a bug per se and it is an opiniated decision, one the theme can easily override. I for one think 100% is a better default than any fixed width, but yeah, please comment your opinions :)

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this one and though it could technically impact themes, the impact is not a negative on in my opinion. Thanks @thabaum !

@david-poindexter david-poindexter merged commit f616718 into dnnsoftware:develop Dec 9, 2019
@valadas
Copy link
Contributor

valadas commented Dec 9, 2019

Cool, @thabaum not a big issue but when you mention an issue just with the pound sign, it only creates a link to it. If you add the words Fixes, Fix, Closes or Close and a few others, it will also auto-close the issue when the PR is merged. Like I said, no big deal just a little thing to know about to automate the process :) See https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords for details.

@thabaum thabaum deleted the patch-19 branch December 7, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants