Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-install module with skin causes install failure #3536

Closed
2 tasks
leedavi opened this issue Feb 3, 2020 · 12 comments
Closed
2 tasks

Re-install module with skin causes install failure #3536

leedavi opened this issue Feb 3, 2020 · 12 comments

Comments

@leedavi
Copy link
Contributor

leedavi commented Feb 3, 2020

#3319 Description of bug
Re-installing a module that installs a skin fails, with an error message the skin already exists,

Steps to reproduce

  1. Install OpenStore https://github.com/openstore-ecommerce/OpenStore/releases
  2. re-install OpenStore.

Current behavior

  1. Works
  2. Failes with skin error.

Expected behavior

Both installs should work.

Error information

Not got it.. but Fails with duplicate name or something like that.

Affected version

  • 10.0.0 alpha build
  • 9.5.0 alpha build
  • [X ] 9.4.4 latest supported release
@valadas
Copy link
Contributor

valadas commented Feb 6, 2020

We are talking about a repair install like all the packages have the same version? Or is this a new version and if so did all the packages version had their versions bumped?

@leedavi
Copy link
Contributor Author

leedavi commented Feb 6, 2020

It's only on repair installs. If you remove the "Skin" from the DNN manifesto, the repair works OK.

@leedavi
Copy link
Contributor Author

leedavi commented Feb 20, 2020

My Statement before was wring. This is for ANY install repair or now. If the skin is already there DNN will NOT install the module.

@stale
Copy link

stale bot commented May 20, 2020

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label May 20, 2020
@leedavi
Copy link
Contributor Author

leedavi commented May 21, 2020

This is still active AFIK. I have had to create 2 install packages, to overcome the problem.

@stale stale bot removed the stale label May 21, 2020
@valadas valadas added this to the Future: Patch milestone Jul 28, 2020
@stale
Copy link

stale bot commented Oct 26, 2020

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Oct 26, 2020
@leedavi
Copy link
Contributor Author

leedavi commented Oct 27, 2020

This is still active AFIK. I have had to create 2 install packages, to overcome the problem.

@stale stale bot removed the stale label Oct 27, 2020
@stale
Copy link

stale bot commented Jan 25, 2021

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jan 25, 2021
@leedavi
Copy link
Contributor Author

leedavi commented Jan 26, 2021

This is still active AFIK. I have had to create 2 install packages, to overcome the problem.

@stale stale bot removed the stale label Jan 26, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jun 2, 2021
@leedavi
Copy link
Contributor Author

leedavi commented Jun 3, 2021

Still active. but I doubt it will ever be fixed. Maybe it should be closed to concentrate of more important things.

@stale stale bot removed the stale label Jun 3, 2021
@valadas
Copy link
Contributor

valadas commented Jun 3, 2021

Well, the purpose of stalebot is to close issues that have no progress due to nobody caring hard enough to even keep the conversation rolling. But every time someone comments "still and issue" or similar without anything to help the issue get some possible code contribution, well it's just stale longer :) I gonna close it but if anyone has the intention to work on this, just comment and I'll reopen.

@valadas valadas closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants