Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #3318 #3319

Conversation

coretoco
Copy link
Contributor

Closes #3318

Summary

The TrackingId should be uppercase to work with Google Analytics.

@dnfclas
Copy link

dnfclas commented Nov 20, 2019

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on issue #3318 regarding testing and confirmation of bug. Great PR @coretoco - thank you for the contribution!

The only problem I see is this is targeting the development branch. To get this fix into 9.4.3, we will need to switch the target to the release/9.4.x branch. I will try to do that manually here now and see if it works.

@david-poindexter david-poindexter changed the base branch from development to release/9.4.x November 20, 2019 17:58
@david-poindexter david-poindexter changed the base branch from release/9.4.x to development November 20, 2019 17:58
@david-poindexter
Copy link
Contributor

@coretoco can you update this PR to target the release/9.4.x branch instead of development. We apologize for any confusion with the branching at this time. We are working to make this more for DNN v10 and beyond.

@coretoco
Copy link
Contributor Author

@david-poindexter thank you for your feedback.
I created a new PR (#3322) into release/9.4.x and will close this one now.

@coretoco coretoco closed this Nov 20, 2019
@coretoco coretoco deleted the bug/GoogleTrackingID-tolower branch November 20, 2019 19:02
@sleupold sleupold mentioned this pull request Jan 15, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analytics TrackingID is stored in lowercase
3 participants