Updated contributing guide for GitHub issues #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyeHoefling
changed the title
|
I think we just need the issue number in the body of the PR (and, optionally, body of the commit message), having it in the PR/commit title doesn't seem to make a difference. For example |
SkyeHoefling
changed the title
|
I think I am going to clean this up a little based on your feedback |
|
@ahoefling I pushed a commit with a change more like what I'm thinking (feel free to adjust how you see fit) |
|
@bdukes I didn't see your message and I squashed the commits. Can you reapply it? Sorry about that, should have checked here before I squashed. |
|
@ahoefling how's that look? |
|
Looks good to me |
…ue ID in the PR and no longer needing the jira ID in the commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated contribution guide to use GitHub Issues instead of JIRA issues
#2044