#2053 - Update Contributing Document #2113
Conversation
… basic how to fork commands for new developers
ohine
requested review from
bdukes,
tpluscode,
erikvb,
donker and
mitchelsellers
| @@ -60,12 +61,6 @@ appropriate to start the first line of a commit with '(doc)' instead of | |||
| a ticket number. | |||
|
|
|||
| ```` | |||
| (doc) Add documentation commit example to CONTRIBUTING | |||
There was a problem hiding this comment.
Why were the first lines of the example commit messages removed? I think these either need to be complete examples (as they previously were) or they need to be removed altogether and replaced with a link to documentation on writing a good commit message.
There was a problem hiding this comment.
It seemed like boilerplate text which didn't make sense to me. If it does make sense to keep, I'll add it back. L31-L38 and L63-L68 are the blocks I'm referencing.
There was a problem hiding this comment.
It is a little confusing, but it's supposed to be an example commit message (for a commit about adding the commit message example, which is probably why it gets confusing). Maybe using a more concrete example would be better.
There was a problem hiding this comment.
How is the latest update?
|
I like it, but it would also be nice to show how to build from sources, if people only get this repo, they are not getting a working Dnn, so how should this be done, is there a way to get this + persona bar + pb module, etc. into a single location, build from github sources and then have all that in visual studio to edit, build test. Or do people just get the zipped sources from Dnn Nightly buil and then move over the change into the VS Project cloned from here? |
|
Agreed, @valadas. We're working on getting the build and packaging more streamlined, but until then, there should probably be a note to start with a package from the nightly feed (is this still being updated, with the changes being made to the CI?). Once we have the packaging of the various components coming together, we can hopefully update to a much simpler process. |
ohine
added
Community
Summary
This updates our contributing guide to point people to the current issue tracker (it was still linked to jira). I also added commands required to get git setup for the first time and to help other users rebase their forks to the current code base.
If @dnnsoftware/tag has any other suggestions, lets hear them so we can help everyone participate together!
Fixes #2053