add new sharpziplib assembly name to ignore list - Issue #2095 #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohine
changed the title
ohine
changed the title
bdukes
requested changes
Jun 21, 2018
|
Woops, I totally missed that too. Closing it now. Thanks @bdukes! |
ohine
added
Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the updated
SharpZipLibassembly name to the ignore list of assemblies to scan for Dnn features and extension points.Details
In v9.2.0 the assembly was updated but the
CanScanfunction wasn't. This pull request updates Dnn to be aware of both assemblies since in v9.2.1 we are attempting to solve the breaking change for any module developers who were directly referencingSharpLibZip