Fix Newtonsoft.Json package install during DNN Upgrade. #2271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121
Summary
The Config component in the manifest of Newtonsoft.Json package is not needed. The binding redirect is ensured by the AssemblyInstaller through the AddOrUpdateBindingRedirect() method call inside the InstallFile() method.
This also broke the DNN upgrade from a version prior to 9.2.0 when the web.config contained additional
<codebase>
assembly bindings before the one with the<bindingRedirect>
.Moreover besides that, it also updated the web.config with the binding redirect twice, in both scenarios (clean install and DNN upgrade).