Google Analytics: TrackAdmin, AnonymizeIp, and TrackUserID Support #2785
Conversation
DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs
Outdated
Show resolved
Hide resolved
| @@ -105,7 +106,7 @@ define(["jquery", "knockout", "templatePath/scripts/config", "templatePath/scrip | |||
|
|
|||
| // Set the isDeactivating flag to true to override the default save behaviour | |||
| // Temporary workaround until delete functionality on connectors is improved | |||
| conn.configurations[3].value("true"); | |||
| conn.configurations[5].value("true"); | |||
There was a problem hiding this comment.
Is there any way to get away from mysterious numbers defining these values?
There was a problem hiding this comment.
Agreed, It's something I'd also like to fix, but I didn't have time this morning to look into the configuration property in the connector engine. I'm looking at it now to see if we can remove those and replace them with the name of the setting.
|
|
||
| if (trackingUserId) | ||
| { | ||
| sb.AppendFormat("ga('set', 'userId', {0});", UserController.Instance.GetCurrentUserInfo().UserID); |
There was a problem hiding this comment.
should this check if they're logged in? or do we want to track -1?
There was a problem hiding this comment.
I grabbed that code from my old GA extension, and it was running for all users in that extension.
However, I can see pros/cons for either way. I'm good with -1 for guests or adding a check IsAuthenticated prior to setting the UserId var in GA. Whichever sounds best to the @dnnsoftware/approvers i'll make happen with another commit.
Summary
This PR fixes #2782 and also implements
AnonymizeIpandTrackUserIDsettings in Google Analytics.