Fix potential XML namespace bug #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependentAssembly elements will be imported into the web.config, and need to have the correct namespace there For #2971
|
Since this is not regression, I have assigned it to 9.4.1, let me know if you want to to it differently... |
1 task
|
Very cool, awesome & thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background for this issue is documented in #2971. This PR fixes a bug that can be introduced when using
collision="save"with an incorrectly created XML Merge file. This can result in an element with a namespace being replaced by an element that has the namespace reset (e.g.<dependentAssembly xmlns="">), resulting in that element being ignored.