Portal settings setters should not persist to DB #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… portalsettings object
bdukes
approved these changes
Sep 27, 2019
|
Since this modifies a public property behaviour, I would vote to retarget this to Dnn10 to be extra-safe. Thoughts? Is this change mainly for cleanup/performance or does it cause a bug? |
|
@donker can you confirm this is actually a bug in the new code? |
mitchelsellers
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroneously the earlier code copied the pattern from TimeZone and persisted to the database the value being set. But the controller that fills this object passes through here so the PortalSettings keep getting reset and not being cached. This also raises the question whether TimeZone should be refactored.