Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of the AdminExperience repository #3041

Merged
merged 5,779 commits into from
Oct 2, 2019

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Sep 30, 2019

At this stage this is just to test merging the admin experience repository into the main repository, please do not merge yet.

ohine and others added 30 commits February 20, 2019 00:30
Update master with fixes from v9.3.0-rc2
…nnsoftware#410)

* DNN-29318 PB > Site Settings > Languages shows language settings of Portal 0

* DNN-29318 PB > Site Settings > Languages shows language settings of Portal 0

* DNN-29318 PB > Site Settings > Languages shows language settings of Portal 0
* Makes users module show up in IE11

* Reverts debugging settings for a minified final output
…ftware#431)

* DNN-29460 DNN Platform -> Settings -> Site Settings -> Languages -> Blank Language Page is displayed in IE Browser

* Minor formatting
Update development with fixes from v9.3.0-rc
@david-poindexter
Copy link
Contributor

Tested locally and this looks really good for me - thanks @valadas!

@mitchelsellers
Copy link
Contributor

I looked at this also, this looks great.

Administrative question - do we squash merge this, or do we retain history? (If not squashed, @valadas you are going to get a lot of internet points for this one!)

@valadas
Copy link
Contributor Author

valadas commented Oct 1, 2019

For people reviewing this, mainly looking for developer experience.

  1. git clone -b pb-merge https://github.com/valadas/Dnn.Platform
  2. open powershell as admin and run ./Build.ps1 -Target BuildAll
    Let it build then verify the following

** Status should be clean **
git status should show nothing to commit (providing there was no build errors that stopped the buidl midway in which case, you should run git reset --hard and try again fixing what caused the error.

** You should have 4 zips in the Artifacts folder **
Try a clean install.
Try an upgrade.
Verify the Persona Bar works and gets 9.4.2 version

@valadas valadas marked this pull request as ready for review October 2, 2019 06:14
@mitchelsellers
Copy link
Contributor

Per agreement with the Approvers group, I am merging this with a single approval as part of the Build Support processes.

@mitchelsellers mitchelsellers merged commit ecd98ad into dnnsoftware:release/9.4.x Oct 2, 2019
@mitchelsellers mitchelsellers changed the title Tests a merge of the AdminExperience repository Merge of the AdminExperience repository Oct 2, 2019
@mitchelsellers mitchelsellers added this to the 9.4.2 milestone Oct 2, 2019
@valadas valadas mentioned this pull request Oct 18, 2019
3 tasks
@valadas valadas deleted the pb-merge branch December 31, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.