Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(doc) Update pull request process documentation #3063

Merged
merged 1 commit into from
Oct 3, 2019
Merged

(doc) Update pull request process documentation #3063

merged 1 commit into from
Oct 3, 2019

Conversation

youngcaseho
Copy link
Contributor

Summary

Fixed typos in the Pull Request Process document.

@dnfclas
Copy link

dnfclas commented Oct 3, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

bdukes
bdukes approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

valadas
valadas approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This could have targeted the release/9.4.x branch instead but it's ok since people will get on development branch by default when viewing the page.

@valadas valadas merged commit 4508909 into dnnsoftware:development Oct 3, 2019
@youngcaseho
Copy link
Contributor Author

youngcaseho commented Oct 3, 2019 •
edited
Loading

Approved. This could have targeted the release/9.4.x branch instead but it's ok since people will get on development branch by default when viewing the page.

Thanks for pointing that out Daniel.

@youngcaseho youngcaseho deleted the github/doc-update-pull-request-process branch October 3, 2019 21:12
DnnSoftwarePersian pushed a commit to DnnSoftwarePersian/Dnn.Platform that referenced this pull request May 17, 2020
@youngcaseho @DnnSoftwarePersian
(doc) Update pull request process documentation (dnnsoftware#3063)
2c856b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngcaseho @dnfclas @bdukes @valadas