Add 'fileName' to condition when checking request for logo file. #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Steps
Expected Result: "Settings have been updated" message should appear without error.
Expected Results: No logo should be displayed in the Site Logo area.
Fixes #3095
Summary
The issue here is that the 'folderPath' property on the 'LogoFile' request object is populated with the path that the user selects from the 'Folder' drop-down list, making the request.LogoFile object != null. Because request.LogoFile was not null, the previous logic attempted to retrieve the file even when 'None Specified' was selected from the 'File' drop-down list. I added 'fileName' to the condition to ensure that a file is selected from the 'File' drop-down list before attempting to retrieve the file.