Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe access to UrlReferrer in Log404 #3341

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Add safe access to UrlReferrer in Log404 #3341

merged 2 commits into from
Dec 6, 2019

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Nov 25, 2019 •
edited by valadas
Loading

This is a rebase of #3340 onto release/9.4.x for @engineering87

Closes #3339

engineering87 and others added 2 commits November 25, 2019 13:45
@engineering87 @bdukes
Add safe access to UrlReferrer in Log404
739efff 
Allow safe access to the UrlReferrer property in Log404 in case of bad format Url
@engineering87 @bdukes
Catch specific exception type in UrlReferrer
4f396de 
Change from general Exception to UriFormatException
@bdukes bdukes changed the title Sharpcode it pr 3340 Add safe access to UrlReferrer in Log404 Nov 25, 2019
@bdukes bdukes mentioned this pull request Nov 25, 2019
Closed
@engineering87 engineering87 mentioned this pull request Nov 25, 2019
Closed
3 tasks
@valadas valadas added this to the 9.5.0 milestone Nov 29, 2019
valadas
valadas approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas changed the base branch from release/9.4.x to develop December 3, 2019 23:48
@bdukes
Copy link
Contributor Author

bdukes commented Dec 6, 2019

@mitchelsellers @david-poindexter since I recreated this PR, I can't give the second approval. Can one of you greenlight this for me?

@mitchelsellers mitchelsellers merged commit 3eb2fb8 into dnnsoftware:develop Dec 6, 2019
@bdukes bdukes deleted the sharpcode-it_pr-3340 branch July 28, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@ohine ohine ohine approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

UrlReferrer format exception in Log404
5 participants
@bdukes @ohine @mitchelsellers @valadas @engineering87