Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the module id from query string correctly when redirect mixed case option enabled. #3438

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Get the module id from query string correctly when redirect mixed case option enabled. #3438

merged 1 commit into from
Jan 13, 2020

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Dec 30, 2019

Fix #3437

@mitchelsellers mitchelsellers changed the title DNN-34520: get the module id from query string correctly when redirect mixed case option enabled. Get the module id from query string correctly when redirect mixed case option enabled. Dec 31, 2019
donker
donker approved these changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have a bool in the GetValueOrDefault methods so as to avoid these issues in the future. But this will do for now.

valadas
valadas approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas added this to the 9.5.0 milestone Jan 13, 2020
@valadas valadas merged commit a83a3e2 into dnnsoftware:develop Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@donker donker donker approved these changes

Assignees
No one assigned
Labels
Area: Platform > Library Effort: Low Priority: Medium Status: Closed Type: Bug
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

moduleid can't detect in mvc path when redirect mixed case option enabled
3 participants
@zyhfish @donker @valadas