Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN-35360 - Azure Storage connector changes its name on disconnect #3449

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

berkarslan-xo
Copy link
Contributor

@berkarslan-xo berkarslan-xo commented Jan 3, 2020

Fixes #3448

Summary

Since the other connector names are in single word (except Amazon S3), this situation is specific to the connector names with multiple words because it was resetting the displayName property by the name property which can be different from the displayName (like "Azure" and "Azure Storage") so that it's bound to the correct property now.

Demo: https://drive.google.com/file/d/1ArAiSShbeg6cd5chSysR2RPxLYrX3kvy/view

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Storage connector changes its name on disconnect
4 participants