Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javascript Libraries Referenced #3475

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

mitchelsellers
Copy link
Contributor

This is a mutl-part update that updates the jQuery & jQuery Migrate references to newer versions. Additionally, due to a limitation in how DNN loads jQuery it also loads the Minified versions by default rather than the full version to reduce the payload for all pages.

In this change, we did the following

  • Updated jQuery to the most current version 3.4.1 - Which should be a low/no risk
  • Updated jQuery-Migrate to the most current version 3.1.0 - WHich should be low/no-risk
  • Additionally updated the /Resources/shared/scripts/jquery folder with these files - As the true usage is unknown for those folders.

Initial testing has been completed, however, it is suggested that we Merge commit this, in case we need to roll back one of the individual changes.

This also resolves #2901 as well

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdukes bdukes merged commit 24977c7 into dnnsoftware:develop Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jquery migrate and minify
3 participants