Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DNN Copyright Injection #3524

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Remove DNN Copyright Injection #3524

merged 4 commits into from
Jan 27, 2020

Conversation

mikesmeltzer
Copy link
Contributor

@mikesmeltzer mikesmeltzer commented Jan 27, 2020 •
edited by david-poindexter
Loading

Fixes #2791
Fixes #3088

  • Remove copyright and meta data injection logic
  • Remove Persona Bar UI elements and corresponding items that control the injection logic

This was referenced Jan 27, 2020
Closed
Closed
valadas
valadas approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is only in the persona bar so no worries about deprecating it. In the Dnn API I would prefer to deprecate the logic

@valadas valadas added this to the 9.5.0 milestone Jan 27, 2020
@mikesmeltzer mikesmeltzer mentioned this pull request Jan 27, 2020
Closed
@mitchelsellers mitchelsellers merged commit b0abde7 into dnnsoftware:develop Jan 27, 2020
@mikesmeltzer mikesmeltzer deleted the RemoveDnnCopyright branch December 24, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

Duplicate Display DNN Copyright Setting Remove Display DNN Copyright Functionality
4 participants
@mikesmeltzer @bdukes @valadas @mitchelsellers