-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix performance #3539 #3540
fix performance #3539 #3540
Conversation
thanks to Eugene Shalyuk (@eugene-sea) for bringing up this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some local testing on a large DB this seems to preform well.
@sleupold what issue does this PR address? @mitchelsellers are we trying to get this in 9.5.0 or 9.5.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I would be nice next time to have a human readable title only and to put something like: |
thanks for the instructions, @valadas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sleupold @mitchelsellers found this while upgrading some of our internal sites.
DROP PROCEDURE {databaseOwner}[{objectQualifier}CoreMessaging_GetNextMessagesForDigestDispatch]; | ||
GO | ||
|
||
CREATE PROCEDURE [dbo].[CoreMessaging_GetNextMessagesForDigestDispatch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databaseOwner
and objectQualifier
were needed here. Because of this, the Scheduler in 9.5.0 fails to execute this stored procedure.
FROM {databaseOwner}[{objectQualifier}CoreMessaging_MessageRecipients] R | ||
JOIN (SELECT TOP (@BatchSize) | ||
UserID | ||
FROM dbo.[vw_MessagesForDispatch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well.
Thanks for spotting that @dimarobert , however this was already merged. Could you create a new issues about this to make it more actionable please, and well if you can submit a PR that fixes it, even better :) |
I'll create a PR for DNN 9.5.1 |
@dimarobert |
thanks to @eugene-sea for bringing up and testing this issue.