Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN-30135 - Issue when loading the Persona Bar: Not Thread Safe #3640

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

berkarslan-xo
Copy link
Contributor

@berkarslan-xo berkarslan-xo commented Mar 24, 2020

Note: This is the duplicate PR of dnnsoftware/Dnn.AdminExperience#1126 . I do it again now since it wasn't merged here after Dnn.AdminExperience is migrated here.

Fixes dnnsoftware/Dnn.AdminExperience#1125

Summary
The problem lies in "Dnn.PersonaBar.Library.Repository.PersonaBarRepository.GetMenuItem(string identifier)" method which is called from "Evoq.PersonaBar.UI.Controllers.EvoqPersonaBarContainer.Initialize(UserControl personaBarControl)". GetMenuItem method doesn't exist in the StackTrace because JIT (Just-In-Time) Compiler does Inline Code Optimizations for release builds which basically means that some methods (especially like the ones that are only a few lines) get inlined into the previous method chain for performance reasons. Therefore, if you have a method call chain like A -> B -> C, it might become A -> B if C is inlined (you might think of it as method C's code gets copied under method B).

Using a list instance which might change state in loops (FirstOrDefault method iterates the elements one by one which behaves like a loop) will raise that error when the list gets updated while iterating. The solution is to use ToList method to copy the list's current state into another list and then use it instead for iteration. You can watch the following video I shot a demo video which demonstrates the issue: https://drive.google.com/open?id=13bneeDRu2aqicSvJ-QtV2okoPUivkHh4

@bdukes
Copy link
Contributor

bdukes commented Mar 24, 2020

Looks like this was merged into the development branch of Dnn.AdminExperience previously (56fe843). What's our 9.5.1 timeline, are we accepting hotfixes like this? @valadas @mitchelsellers

@mitchelsellers
Copy link
Contributor

@bdukes Lets chat at the meeting today

@berkarslan-xo
Copy link
Contributor Author

berkarslan-xo commented Mar 24, 2020

Please note that I raised this PR since @v-karbovnichy asked me to.

@valadas valadas added this to the 9.5.1 milestone Mar 24, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@donker donker merged commit c55e0d7 into dnnsoftware:release/9.5.1 Mar 24, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
mtrutledge added a commit to mtrutledge/Dnn.Platform that referenced this pull request Jun 16, 2020
* Fixes to build process (dnnsoftware#3618)

* Fixes to build process

* Last fix

* Fixed jquery.ui.widget 404

* Fixed jquery.ui.widget 404

* Update DNN Platform/Library/Data/DataProvider.cs

Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>

* Update DNN Platform/Library/Common/Utilities/FileExtensionWhitelist.cs

Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>

* Fix errors setting up dev site (dnnsoftware#3642)

* Don't re-use MVC controllers (dnnsoftware#3635)

Fixes dnnsoftware#3634, thanks @DaveMartinSE!

Error message states:
>If a custom controller factory is in use, make sure that it creates a
>new instance of the controller for each request.

* DNN-30135 - GetMenuItem is made thread-safe (dnnsoftware#3640)

* check message attachment's permission.

Fix dnnsoftware#3644.

* Fix broken unit tests.

* Replacing text-indent css property with margin-left, to insure wrapping text will all start at the same left position.

* Fixed the issue that causes all modules to be relocated to same pane if an existing module from other tab is on the page. (dnnsoftware#3652)

* validate file upload request. (dnnsoftware#3655)

* validate file upload request.

Fix dnnsoftware#3654.

* including the portal id and user id parameter.

* Ensure the portal ID being used for consent is the parent portal

Fixes dnnsoftware#3662

* https://jira.devfactory.com/browse/DNN-33796
Invalid Username/Email Address When Containing "onfocus"

* Fixed Allow Indexing module setting

* Fixes dnnsoftware#3658 by allowing a superuser to be returned for this query

* Make sure to look up user against effective portal

* Fix Batch issue

fix an issue determing the batch size

* First migration of SCullman's Connect.SiteGroups project

* Remove trace statements from adapter

* Ensure proper logging of SiteGroup operations from within controller

* Centralize logging for portal creation and deletion in the controller

* SQL changes for logging of portal and portalgroup operations

* Improvements to UI

* DNN-36093: fixed portal alias update on website change

* Improve portal groups logging migration script to log by default

* WIP

* WIP

* WIP

* Remove images stuff for now. It doesn't look like this would work.

* Clean

* Set template and upgrade for host setting

* Recheck all portals after the host has changed the value for extensions list

* Fix

* UI for new host setting

* Editing of the portal setting for whitelist

* Fix

* Fixes for lack of context during install

* Update DNN Platform/Library/Data/DataProvider.cs

Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>

* Update DNN Platform/Library/Common/Utilities/FileExtensionWhitelist.cs

Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>

* Uninstall provider

* Updates version to 9.6.0

This updates gitversion.yml so that CI builds version 9.6.0
as we decided this would be the next version.

This is a release management task and we are self-approving
it for that reason

* Adjusted Telerik Bindings (dnnsoftware#3673)

* Fixes dnnsoftware#3671 (dnnsoftware#3674)

* Adjusted Telerik Bindings

* Proper Telerik Fix

* Ensure default end users whitelist is there during upgrade and for testing

* Remove double entry from project

* should be applied to all other similar "js event" words

* Bring UI button to access export portal template - fix some bugs in the old code (dnnsoftware#3675)

* jQuery 3.5.0 (dnnsoftware#3685)

* Update jQuery to 3.5.0

* Update jQuery-Migrate to 3.2.0

* Fix CDN URL for jQuery

* Remove items from default web.config (dnnsoftware#3683)

* Add DI support to scheduler

* Provide better feedback to end users in case something went wrong when trying to export content

* Correct CONTRIBUTING link in bug-report issue template

* Correct CONTRIBUTING link in enhancement-request issue template

* Change module export to use the .export extension

* DNN-37509: fixed user role icons not showing

* Corrects typos and errors in module settings resx

Corrects some typos and errors in module settings localization files

* Add Services Framework call to Toast skin object

* DNN-25441: fixed module content export validation (dnnsoftware#3721)

* Bump version to 9.6.0

PR dnnsoftware#3719

* Redo PR dnnsoftware#3333

* Update bug-report.md

* Optimised images with calibre/image-actions

* Update jQuery to 3.5.1 (dnnsoftware#3729)

* Fixed an issue with search results page rendering (dnnsoftware#3736)

* Fixed an issue with search results page rendering

Closes dnnsoftware#3712

Due to jQuery 3.5.0 not supporting shortcuts to closing html tags in templates:
ie: <div class="something" /> is no longer supported and needs to be rewritten as <div class="something”></div>

This PR fixes those instances used in the jQuery code for the search results.

* Rever change on input

* Change "Dotnetnuke Professional" to "DNN Platform" in 2 releasenotes txt files Fixes dnnsoftware#3739

* Update date in sln info file (dnnsoftware#3737)

* Update date in sln info file

* Optimised images with calibre/image-actions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adds action to automated versioning on RC (dnnsoftware#3741)

Upon creation of a release/x.x.x branch, updates the following:

- Updates all versions in Dnn manifests
- Updates AssemblyInfo
- Adds RC to issue template
- Updates versions in package.json files

This can only be tested upon creation of a release
branch so we need to merge this before release/9.6.1 in order to test it.

Example usage in a copy of this repository:
Action: https://github.com/valadas/Dnn.Platform.Copy/runs/654270580?check_suite_focus=true

PR generated: valadas/Dnn.Platform.Copy#20

* Locks versions of image-actions (dnnsoftware#3742)

* Locks versions of image-actions

* Fixed typo on version

* Updates versions as per release candidate creation

* Update updateVersions.yml

* Limit rc action to run only on release branches

An issue was found where the action would run on any branch.
By mistake the filter was on just one of the steps
instead of the whole action.

This PR fixes that and applies the filter to the whole action.

This is a release management task and we are self-approving it for that reason

* Restores icons in language editor

Closes dnnsoftware#3754

There was a breaking change with I believe raw-loader or file-loader
or svg-loader or some such, we already had 2 other similar PRs for
this same issue in other areas.

After that dependency update, I think in 9.5.0,
we now need to add `.default` at the end of svg imports.

This fixes the same issue in the language resources editor.

I did a search to find if we missed this in other spots and did not find
any other instance.

* Fixes some errors in exceptions localization (dnnsoftware#3748)

Fixes some errors in exceptions localization

* DB Performance Improvement (dnnsoftware#3758)

Tested performance configuration to fix dnnsoftware#3757 for 9.6.2

* Fix to settings saving in MVC modules

* Fix broken tests

* improvement when no portal locale is defined

* select primary site alias by default

* Update nl-NL local resources for the Upgrade & Install wizard
Close dnnsoftware#3742

* Fix logo/icon upload in site setting for dnnsoftware#3722 (dnnsoftware#3769)

* Fix logo/icon upload in site setting for dnnsoftware#3722

* Remove unrelated code for dnnsoftware#3722

* Updated cleaned versions of the nl-NL default & blank site
Close dnnsoftware#3764

* Fix weird shorting in site settings PB heading

* adjust version

fix dnnsoftware#3783

* Update bug-report.md

* Remove or update logo in distribution (dnnsoftware#3786)

* Revert in favor for more global fix approach

* Improves deprecation of search indexes

Closes dnnsoftware#3776

Please read the issue during review. This is what comes to mind, but if there are better ideas, I am open to them :)

* Remove 3 obsolete keys and adjust description of admin message.
Fixes dnnsoftware#3781 and fixes dnnsoftware#3782

* Remove obsolete Dutch template files (should be in LP only)
fixes dnnsoftware#3789

* Improved wording dnnsoftware#3785 (dnnsoftware#3788)

* Fix dnnsoftware#3604 (missing tokens)

* Improve wording
fixes dnnsoftware#3785

* Add stylecop.config

* Update Microsoft.AspNet.Razor to 3.1.2

* Update Microsoft.AspNet.WebPages to 3.1.2

* Add StyleCop.Analyzers

* Update copyright statements

* Revert "Add StyleCop.Analyzers"

This reverts commit 3f8b47dbeeaf2c8745a070ed35e9a77d1b26cb43.

Platform/DotNetNuke.DependencyInjection/DotNetNuke.DependencyInjection.csproj
Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj
Platform/Modules/HtmlEditorManager/DotNetNuke.Modules.HtmlEditorManager.csproj
Platform/Modules/MemberDirectory/DotNetNuke.Modules.MemberDirectory.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/DotNetNuke.Authentication.Facebook.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/packages.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/DotNetNuke.Authentication.Google.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/packages.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/DotNetNuke.Authentication.LiveConnect.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/packages.config
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/DotNetNuke.Authentication.Twitter.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/packages.config
Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider.csproj
Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/packages.config
Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/DotNetNuke.Providers.AspNetCCP.csproj
Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/packages.config
Platform/Providers/FolderProviders/DotNetNuke.Providers.FolderProviders.csproj
Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj
Platform/Tests/DotNetNuke.Tests.AspNetCCP/DotNetNuke.Tests.AspNetCCP.csproj
Platform/Tests/DotNetNuke.Tests.Authentication/DotNetNuke.Tests.Authentication.csproj
Platform/Tests/DotNetNuke.Tests.Integration/DotNetNuke.Tests.Integration.csproj
Platform/Tests/DotNetNuke.Tests.Utilities/DotNetNuke.Tests.Utilities.csproj
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj
Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj
Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Pages.Tests/Dnn.PersonaBar.Pages.Tests.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Security.Tests/Dnn.PersonaBar.Security.Tests.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Users.Tests/Dnn.PersonaBar.Users.Tests.csproj

* Revert "Update Microsoft.AspNet.WebPages to 3.1.2"

This reverts commit a0a7ab64b0671b9bb873d81f84ed3bec859f8867.

* Revert "Update Microsoft.AspNet.Razor to 3.1.2"

This reverts commit 77b2159dec783941ce2a25dfb0f971e5ba601123.

Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj
Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj
Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj
Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj

* Revert "Add stylecop.config"

This reverts commit 154d4d6df74de6fea58ecd83324171e0aa40da57.

Platform/DotNetNuke.DependencyInjection/DotNetNuke.DependencyInjection.csproj
Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj
Platform/Modules/HtmlEditorManager/DotNetNuke.Modules.HtmlEditorManager.csproj
Platform/Modules/MemberDirectory/DotNetNuke.Modules.MemberDirectory.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/DotNetNuke.Authentication.Facebook.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/DotNetNuke.Authentication.Google.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/DotNetNuke.Authentication.LiveConnect.csproj
Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/DotNetNuke.Authentication.Twitter.csproj
Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider.csproj
Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/DotNetNuke.Providers.AspNetCCP.csproj
Platform/Providers/FolderProviders/DotNetNuke.Providers.FolderProviders.csproj
Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj
Platform/Tests/DotNetNuke.Tests.AspNetCCP/DotNetNuke.Tests.AspNetCCP.csproj
Platform/Tests/DotNetNuke.Tests.Authentication/DotNetNuke.Tests.Authentication.csproj
Platform/Tests/DotNetNuke.Tests.Integration/DotNetNuke.Tests.Integration.csproj
Platform/Tests/DotNetNuke.Tests.Utilities/DotNetNuke.Tests.Utilities.csproj
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj
Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj
Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Pages.Tests/Dnn.PersonaBar.Pages.Tests.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Security.Tests/Dnn.PersonaBar.Security.Tests.csproj
Dnn.AdminExperience/Tests/Dnn.PersonaBar.Users.Tests/Dnn.PersonaBar.Users.Tests.csproj

* Update outdated links for dnnsoftware#3792 - part 1 - for default cuture

* Add stylecop.config

(cherry picked from commit 810d73a)

* Add StyleCop.Analyzers

(cherry picked from commit 096f19c)

# Conflicts:
#	DNN Platform/DotNetNuke.Web.Deprecated/packages.config
#	DNN Platform/DotNetNuke.Web.Mvc/packages.config
#	DNN Platform/DotNetNuke.Web.Razor/packages.config
#	DNN Platform/DotNetNuke.Web/packages.config
#	DNN Platform/Library/packages.config
#	DNN Platform/Tests/DotNetNuke.Tests.Web.Mvc/packages.config
#	DNN Platform/Website/packages.config

* Fixes a null reference exception with ISearchable (dnnsoftware#3806)

Closes dnnsoftware#3805

This is a followup on PR dnnsoftware#3777

For context the deprecated class had the deprecated method required and the recommended one not required. PR dnnsoftware#3777 deprecated the whole class for easier migration and reversed the required vs the non-required methods so developers can implement the new way without hacks or build warnings.

In that PR, a mistake was made on the deprecated method where we default to return null, but that caused a null reference exception on old modules. This PR replaces that return for an empty collection, which solves the same goal without an exception.

* Delete out-of-date documentation folder

* Configure StyleCop

* Fix random replacement of http with https in resources (issue dnnsoftware#3599)

* Add .editorconfig

* Update stylecop.json

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

* Update stylecop.json

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

* Use newer logic to send SMTP test emails

* Replace DNN Corp copyright in Blank Website and Default Website templates with generic copyright

* StyleCop fixes (dnnsoftware#3811)

* Configure StyleCop

* Add .editorconfig

* Update stylecop.json

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

* Update stylecop.json

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

* SA1101 (prefix local calls with this)

Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>

* Upgrade jquery-hoverintent to latest version (dnnsoftware#3822)

* Change upgrade URL to extension manifest URL instead of the upgrade service redirect (dnnsoftware#3834)

* Update ComposeMessage.js

* Update Settings.ascx

Closes dnnsoftware#3682

* Revert MaxLength change

* Update display of server log files

Use listing similar to Event Log, rather than dropdown
Order by last modified date
Show the size

Co-authored-by: Alex Long <along@engagesoftware.com>
Co-authored-by: Jon Bockhorst <jbockhorst@engagesoftware.com>
Co-authored-by: Eric Wagner <ewagner@engagesoftware.com>
Co-authored-by: Kyle Smith <ksmith@engagesoftware.com>

* Fixed NRE in StandardFolderProvider

* SA1000

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1000.md

* SA1001

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1001.md

* SA1002

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1002.md

* SA1003

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1003.md

* SA1004

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1004.md

* SA1005

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1005.md

* SA1008

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1008.md

* SA1009

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1009.md

* SA1010

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1010.md

* SA1011

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1011.md

* SA1012

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1012.md

* SA1013

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1013.md

* SA1014

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1014.md

* SA1015

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1015.md

* SA1019

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1019.md

* SA1024

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1024.md

* SA1025

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1025.md

* SA1026

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1026.md

* SA1027

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1027.md

* SA1028

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1028.md

* SA1100

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1100.md

* SA1106

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1106.md

* SA1107

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1107.md

* SA1116

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1116.md

* SA1119

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1119.md

* SA1119_p

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1119_p.md

* SA1120

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1120.md

* SA1121

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1121.md

* SA1122

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1122.md

* SA1123

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1123.md

* SA1124

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1124.md

* SA1127

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1127.md

* SA1128

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1128.md

* SA1129

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1129.md

* SA1130

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1130.md

* SA1131

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1131.md

* SA1132

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1132.md

* SA1133

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1133.md

* SA1134

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1134.md

* SA1135

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1135.md

* SA1137

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1137.md

* SA1139

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1139.md

* SA1205

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1205.md

* SA1206

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1206.md

* SA1208

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1208.md

* SA1209

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1209.md

* SA1210

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1210.md

* SA1211

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1211.md

* SA1212

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1212.md

* SA1400

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1400.md

* SA1407

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1407.md

* SA1408

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1408.md

* SA1411

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1411.md

* SA1413

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1413.md

* SA1500

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1500.md

* SA1501

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1501.md

* SA1502

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1502.md

* SA1503

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1503.md

* SA1505

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1505.md

* SA1506

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1506.md

* SA1507

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1507.md

* SA1508

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1508.md

* SA1509

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1509.md

* SA1512

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1512.md

* SA1513

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1513.md

* SA1514

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1514.md

* SA1515

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1515.md

* SA1516

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1516.md

* SA1518

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1518.md

* SA1519

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1519.md

* SA1520

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1520.md

* SA1610

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1610.md

* SA1615

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1615.md

* SA1617

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1617.md

* SA1623

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1623.md

* SA1626

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1626.md

* SA1629

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1629.md

* SA1633

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1633.md

* SA1642

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1642.md

* SA1643

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1643.md

* Added unit test for StandardFolderProvider

* SA1200

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1200.md

* Removed maxlength from ViewProfiles/Settings.ascx (dnnsoftware#3837)

* Update ComposeMessage.js

* Update Settings.ascx

Closes dnnsoftware#3682

* Revert MaxLength change

* Update Settings.ascx

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>

Co-authored-by: Peter Donker <peter@bring2mind.net>
Co-authored-by: Daniel Aguilera <daniel.aguilera@aurea.com>
Co-authored-by: Daniel Valadas <info@danielvaladas.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Berk Arslan <berk.arslan@aurea.com>
Co-authored-by: Sebastian Leupold <leupold@dnnwerk.de>
Co-authored-by: Ben <zyhfish@163.com>
Co-authored-by: Christopher Behling <christopherbehling@Christophers-iMac.local>
Co-authored-by: jacoch <jacques@plurial.net>
Co-authored-by: sergeydryomin <sergey.dryomin@aurea.com>
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Timo-Breumelhof <IP61Rf0GyAlyXwL8U8aT>
Co-authored-by: Peter Schotman <peter@cestuswebsites.nl>
Co-authored-by: Ernst Peter Tamminga <ernst.peter.tamminga@xcess.nl>
Co-authored-by: Gheorghe Bulicanu <gicu@live.com>
Co-authored-by: Gheorghe Bulicanu <gbulicanu@gbfsoft.com>
Co-authored-by: Cody <cody@decacon.com>
Co-authored-by: Michael Tobisch <mt@dnnwerk.at>
Co-authored-by: Alex Long <along@engagesoftware.com>
Co-authored-by: Jon Bockhorst <jbockhorst@engagesoftware.com>
Co-authored-by: Eric Wagner <ewagner@engagesoftware.com>
Co-authored-by: Kyle Smith <ksmith@engagesoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants