Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check message attachment's permission. #3645

Merged
merged 2 commits into from
Mar 26, 2020
Merged

check message attachment's permission. #3645

merged 2 commits into from
Mar 26, 2020

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Mar 26, 2020

Fix #3644.

@valadas
Copy link
Contributor

valadas commented Mar 26, 2020

@zyhfish the tests are failing, is something wrong or we need to adjust the tests ?

@zyhfish
Copy link
Contributor Author

zyhfish commented Mar 26, 2020

@zyhfish the tests are failing, is something wrong or we need to adjust the tests ?

Hi @valadas , the broken tests has been fixed, thx!

@mitchelsellers mitchelsellers added this to the 9.5.1 milestone Mar 26, 2020
@bdukes bdukes merged commit aaeff3d into dnnsoftware:develop Mar 26, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.

check the attachment permission
4 participants
@zyhfish @valadas @bdukes @mitchelsellers