Fixed "Allow Indexing" module setting

[daguiler]

Fixes #3656

Summary

After installation, some modules have no entries in TabModuleSettings or ModuleSettings. This is the case for instance of the "CONNECT and PARTICIPATE" module in the home page. In such cases, a default value is calculated in DNN Platform\Website\admin\Modules\Modulesettings.ascx.cs.

The default value of "Allow Indexing" setting is True, as calculated at line 116 (BindData method):

chkAllowIndex.Checked = Settings["AllowIndex"] == null || Settings["AllowIndex"] != null && bool.Parse(Settings["AllowIndex"].ToString());

but at line 558 (OnUpdateClick method) the expression is different and generates a False default value:

var allowIndex = Settings.ContainsKey("AllowIndex") && Convert.ToBoolean(Settings["AllowIndex"]);

This bug then affects the decision on whether to update the setting or not:

//check whether allow index value is changed
if (allowIndex != chkAllowIndex.Checked)
{
    ModuleController.Instance.UpdateTabModuleSetting(Module.TabModuleID, "AllowIndex", chkAllowIndex.Checked.ToString());
}

resulting in inability to turn it off.

[donker]

LGTM

My only thought is: yet another method to "unnull" a value? Can't we centralize this one day?

[daguiler]

Yes, I agree and I believe this is a step in that direction.