Restores icons in language editor #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dnnsoftware#3754 There was a breaking change with I believe raw-loader or file-loader or svg-loader or some such, we already had 2 other similar PRs for this same issue in other areas. After that dependency update, I think in 9.5.0, we now need to add `.default` at the end of svg imports. This fixes the same issue in the language resources editor. I did a search to find if we missed this in other spots and did not find any other instance.
mitchelsellers
approved these changes
May 11, 2020
bdukes
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3754
There was a breaking change with I believe raw-loader or file-loader
or svg-loader or some such, we already had 2 other similar PRs for
this same issue in other areas.
After that dependency update, I think in 9.5.0,
we now need to add
.defaultat the end of svg imports.This fixes the same issue in the language resources editor.
I did a search to find if we missed this in other spots and did not find
any other instance.
Also, as discussed in Slack, we would like to get this in 9.6.1-rc2 since we have so many contributors right now working on localization and this is a very small front-end only change.