Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Module Creator #4495

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Feb 15, 2021

As of DNN 9.8.1, Module Creator is not included in the distribution of DNN (see #4208)

However, there are other Module Creator references that were left after that removal. There were still references in the database script, so the module would still be created on install, even though the files didn't exist.=
Error message from trying to add Module Creator to a page

Also, the Develop module action was pointing to the module creator. This PR moves it to another View Source control that is shipped with the Platform (presumably what was used before the Module Creator).
Screenshot of old View Source control

As of DNN 9.8.1, Module Creator is not included in the
distribution of DNN (see dnnsoftware#4208)
@bdukes bdukes added this to the 9.9.1 milestone Feb 15, 2021
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @bdukes 🎉

@mitchelsellers mitchelsellers merged commit 603d539 into dnnsoftware:develop Feb 15, 2021
@mitchelsellers mitchelsellers deleted the remove-module-creator branch February 15, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants