Fixed an issue where disabling password strength meter did not disable it in the password reset form #4615
Conversation
| this.passwordContainer.CssClass = "password-strength-container"; | ||
| this.txtPassword.CssClass = "password-strength"; |
There was a problem hiding this comment.
These classes probably should be removed from the ascx file so that they're applied conditionally. Currently, they're already in the ascx file so these lines have no effect.
There was a problem hiding this comment.
Good point. Thanks @bdukes.
|
This was my first PR for the DNN Platform and I noticed I made a few mistakes. One is that the branch name I made the change in is named develop, another is that I left trailing white-space in the .cs file. I know this PR is approved, but I have another fix to submit for a different issue but can't because of the branch name. Should I close this PR and create a new one from a fresh fork with the proper branch name and no white-space since these are small changes anyway? |
|
Yeah, you can resubmit, no problem 👍 |
valadas
changed the title
Summary
Added code similar to Password.ascx.cs to ResetPassword.ascx.cs to fix bug #4595.