Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Azure folder provider cache control #4687

Merged

Conversation

meetmandeep
Copy link
Contributor

@meetmandeep meetmandeep commented May 27, 2021

Summary

Closes #4686

Implementation

Update web.config and add cacheControl attribute as such:

<add name="AzureFolderProvider" type="DotNetNuke.Providers.FolderProviders.AzureFolderProvider.AzureFolderProvider, DotNetNuke.Providers.FolderProviders" providerPath="~/Providers/FolderProviders/AzureFolderProvider/" cacheControl="public, max-age=7776000" />

You may use any valid value for cache-control header. Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas added this to the 9.9.2 milestone May 28, 2021
@valadas valadas changed the title Azure folder provider cache control Added support for Azure folder provider cache control May 28, 2021
@valadas valadas merged commit b32e959 into dnnsoftware:develop May 28, 2021
@valadas valadas modified the milestones: 9.9.2, 9.10.0 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Folder Provider Cache-Control
3 participants