Improve base styling of PersonaBar & EditBar and allow customization #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates hardcoded colors and logo into a theme.css file where integrators can customize the Persona Bar and Edit Bar menu using css variables.
Allows customizing the PersonaBar menu styles
Don't enforce changing core files in order to theme PB
Since `PersonaBar` and `EditBar` are in two separate IFRAMEs, code needed to be refactored to support separate custom CSS files. Also, the purpose of this is to support custom `PersonaBar` and `EditBar` themes without having to modify core files. Custom theme files should be named appropriately (needs documentation) and placed in `/Portals/_default`.
valadas
approved these changes
May 31, 2021
mitchelsellers
requested changes
May 31, 2021
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/theme.css
Show resolved
Hide resolved
mitchelsellers
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4690