Commit linter auto-fixes across JS and JSX files #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependency bot, somewhere along the way, turned on auto-fix. This is simply to commit those auto-fixes by the linter. This will help prevent huge diffs on every local build. Yay!
valadas
approved these changes
May 31, 2021
There was a problem hiding this comment.
Looked at each file in detail, it's mostly whitespace changes, some missing semi-colons, harmonizing strings to use double quotes (which I think makes sense in a C#/JS project like this). My main concern was some changes from var to let but inspected them all and they make sense to me.
This is hard to review in the browser, if anyone else decides to go into details of this one, I recommend using the github visual studio extension to review.
donker
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some dependency bot, somewhere along the way, turned on auto-fix. This is simply to commit those auto-fixes by the linter. This will help prevent huge diffs on every local build. Yay!