Bring back update notification #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referencing #4556 |
david-poindexter
approved these changes
May 31, 2021
There was a problem hiding this comment.
Looks good to me - thanks @donker for all the hard work on this - it's a great improvement!
david-poindexter
previously requested changes
Jun 1, 2021
valadas
approved these changes
Jun 2, 2021
valadas
previously requested changes
Jun 2, 2021
|
Looking at this, 9.9.2 is not a known version since it doesn't exist on GitHub, so it is assumed to be an upgrade available. I think we have 2 options. 1 Update the update service to return the current version if the current version isn't known. |
mitchelsellers
approved these changes
Jun 8, 2021
donker
dismissed stale reviews from valadas and david-poindexter
Just a copy of David's review
bdukes
approved these changes
Jun 22, 2021
|
This PR itself is working as desired, the Update Service needs to be updated yet, which will address the pending behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current framework update service is broken. The proposed solution retrieves the last 5 releases from Github and checks the version of the first non-prerelease/RC version against the installed version. The result is cached and is shown to host users as a clear blue button prompting to upgrade. The button opens a new window with the release on Github visible.