Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced styling for server summary in persona bar #4731

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Enhanced styling for server summary in persona bar #4731

merged 2 commits into from
Jul 6, 2021

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Jul 5, 2021 •
edited
Loading

Summary

This enhances the server summary section of the Persona Bar in the following ways:

  • Update server styling updated to utilize new theming feature via CSS variables.
  • Improved styling overall (thanks @valadas for the suggestion on using the left border).

This PR also cleans up a bunch of CSS formatting issues.

Default look and feel is now this:

image

Here is an example of a themed look and feel:

image

@david-poindexter david-poindexter added this to the 9.10.0 milestone Jul 5, 2021
@david-poindexter david-poindexter self-assigned this Jul 5, 2021
valadas
valadas approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The left border is a nice touch 😝

@mitchelsellers mitchelsellers merged commit 86ff1ab into dnnsoftware:develop Jul 6, 2021
@david-poindexter david-poindexter deleted the update-service-styling branch July 6, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Noteworthy Type: Enhancement
Projects
None yet
Milestone
9.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@david-poindexter @mitchelsellers @valadas