Bump eslint from 5.8.0 to 7.32.0 #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
javascript
|
@mitchelsellers if you need to maintain v9 for a bit while working on v10, I would like to get this into v9 if we can as fixing this only in one branch may cause a lot of merge conflicts. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-7.32.0
branch
2 times, most recently
from
a3cb436 to
a17a9ae
Compare
|
I added a commit that resolves the new ESLint errors, if this makes it in shortly, then I can do an additional PR that will resolve the autofixable warnings before we fire up the new v10 branch. I left that out of the commit on purpose for easier review. I also ran a full build and installed a site with the build result and all the modules load fine. |
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Aug 4, 2021
This adds a `lint` task into all projects with autofix enabled. This will make it easier to auto-fix eslint warnings if we change the configs or while updating eslint dependency in batch using lerna or yarn workspaces. Unfortunatally (well fortunatelly) there was no autofixable warnings to resolve after this change which was my main goal with this PR, anyway, it's still good to have I believe for the future. Also, this PR includes the commits in dnnsoftware#4770 so if it is merged first, this becomes easier to review. If this one gets merged first than dependabot should close dnnsoftware#4770 automatically too.
bdukes
approved these changes
Aug 9, 2021
mitchelsellers
approved these changes
Aug 9, 2021
Bumps [eslint](https://github.com/eslint/eslint) from 5.8.0 to 7.32.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v5.8.0...v7.32.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Dnn.AdminExperience/ClientSide/AdminLogs.Web/src/services/applicationService.js Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/FileUpload/Browse/index.jsx Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/FolderPicker/index.jsx Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/MultiLineInputWithError/index.jsx Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/PagePicker/Service.js Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/PermissionGrid/RoleGroupFilter/Service.js Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/PermissionGrid/Suggestion/Service.js Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/SingleLineInputWithError/index.jsx Dnn.AdminExperience/ClientSide/Pages.Web/src/components/PageDetails/PageUrl/PageExisting/PageExisting.jsx Dnn.AdminExperience/ClientSide/Pages.Web/src/components/PageHierarchy/pages.pageHierarchy.js Dnn.AdminExperience/ClientSide/Pages.Web/src/components/dnn-persona-bar-page-treeview/src/PersonaBarPageTreeviewInteractor.jsx Dnn.AdminExperience/ClientSide/Pages.Web/src/services/languageService.js Dnn.AdminExperience/ClientSide/Security.Web/src/services/applicationService.js Dnn.AdminExperience/ClientSide/Servers.Web/src/services/serviceFramework.js Dnn.AdminExperience/ClientSide/SiteImportExport.Web/src/services/applicationService.js Dnn.AdminExperience/ClientSide/SiteSettings.Web/src/components/languageSettings/index.jsx Dnn.AdminExperience/ClientSide/SiteSettings.Web/src/services/applicationService.js Dnn.AdminExperience/ClientSide/SiteSettings.Web/src/services/languageEditorService.js Dnn.AdminExperience/ClientSide/Sites.Web/src/_exportables/src/services/portal.js Dnn.AdminExperience/ClientSide/TaskScheduler.Web/src/services/applicationService.js Dnn.AdminExperience/ClientSide/Users.Web/src/_exportables/src/services/users.js Dnn.AdminExperience/ClientSide/Vocabularies.Web/src/services/vocabularyService.js
Bumps [eslint](https://github.com/eslint/eslint) from 5.8.0 to 7.32.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v5.8.0...v7.32.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bdukes
force-pushed
the
dependabot/npm_and_yarn/eslint-7.32.0
branch
from
09ad779 to
bf119d7
Compare
|
I've rebased this, good to complete the PR once the new build completes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps eslint from 5.8.0 to 7.32.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
83cc8a67.32.0f10218dBuild: changelog update for 7.32.03c78a7bChore: Adopteslint-plugin/prefer-message-idsrule internally (#14841)faecf56Update: change reporting location forcurlyrule (refs #12334) (#14766)d7dc07aFix: ignore lines with empty elements (fixes #12756) (#14837)1bfbefdNew: Exit on fatal error (fixes #13711) (#14730)ed007c8Chore: Simplify internalno-invalid-metarule (#14842)d53d906Docs: Prepare data for website to indicate rules with suggestions (#14830)d28f2ffDocs: Reference eslint-config-eslint to avoid potential for staleness (#14805)8be8a36Chore: Adopteslint-plugin/require-meta-docs-urlrule internally (#14823)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)