Bump Yarn from from 3.0.0 to 3.0.2 #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also normalize whitespace for packages and update version in yarn.lock
mitchelsellers
approved these changes
Sep 3, 2021
valadas
reviewed
Sep 6, 2021
| @@ -1583,7 +1583,7 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "@dnnsoftware/dnn-react-common@9.9.1, @dnnsoftware/dnn-react-common@workspace:Dnn.AdminExperience/ClientSide/Dnn.React.Common": | |||
| "@dnnsoftware/dnn-react-common@9.10.1, @dnnsoftware/dnn-react-common@workspace:Dnn.AdminExperience/ClientSide/Dnn.React.Common": | |||
There was a problem hiding this comment.
Is this normal or what is going on ?
There was a problem hiding this comment.
We should probably run yarn install when we bump the version so that the lock file gets the current version. This change isn't necessarily related to updating Yarn itself, but every time an install is run it's going to update the version of the workspace in yarn.lock to match package.json.
There was a problem hiding this comment.
Oh, yeah I see, cool. It's not a big deal for this PR, but yeah, let's improve that as another PR
valadas
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog
Also normalize whitespace for
package.jsonfiles and update version inyarn.lock.