-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed getting Folders by Permissions #4897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time to test out this PR, but I did notice the GitHub issue number here and think we should remove probably remove it. We'll have a record of it in the git history.
DNN Platform/Website/Providers/DataProviders/SqlDataProvider/09.10.03.SqlDataProvider
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really funny because I was just looking into this today for a couple of hours and then came here and noticed this PR.
I did run some tests locally and it looks like it's behaving the way it should. Great work!
…9.10.03.SqlDataProvider Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I too tested this one, and it seems to be working well
@yog-it thank you for working on and resolving this! I really appreciate it! And, I would like to thank all of you for your continued work on DNN! I inherited our DNN site a little over 6 years ago upgrading it from 4.9.5 to 7.4.1. Currently we are at 9.7.2. I work with other CMS platforms and DNN is by far the best! Thanks again and long live DNN! |
@cgentryls my pleasure. I too have been a long time DNN user and agree completely, it's just one of the best open source CMS platforms out there. I started contributing only a short while ago, but love working with the project and helping out other DNN'ers. |
@cgentryls and @yog-it thanks so much for your comments - this is what fuels us all! DNN Platform is fantastic and the community is "fantasticer"!!! 😁🎉 |
Fixes #4573
Summary
Retrieving folders per permissions needed to include conditionals for both grant and deny permissions; also using CTE instead of temp table for better performance.