Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error on package parse #5097

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Show error on package parse #5097

merged 2 commits into from
Apr 26, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Apr 21, 2022

Summary

Fixes #5096

@bdukes bdukes added this to the 9.10.3 milestone Apr 21, 2022
valadas
valadas approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

donker
donker approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donker donker merged commit c2615a7 into dnnsoftware:develop Apr 26, 2022
@bdukes bdukes deleted the show-error-on-package-parse branch April 26, 2022 19:49
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@donker donker donker approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

When manifest is missing referenced file, exception is thrown instead of helpful error message
3 participants
@bdukes @donker @valadas