Fix MonacoEditor not loading for child aliases #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Sep 30, 2022
david-poindexter
approved these changes
Sep 30, 2022
|
Did someone test this before merging? I didn't get a chance to yet. |
|
Yes! SOrry I should have noted this, I did test this in multiple installations |
|
Awesome - thanks! |
This was referenced Oct 19, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5322
Summary
This PR updates the SQL Console and Config Manager to load the Monaco editor script using
personaBarSettings.applicationPathinstead ofdnn.getVar("sf_siteRoot").This still needs to be tested on a site hosted in a virtual directory.