-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where resource manager would not have appropriate root folder #5351
Merged
david-poindexter
merged 4 commits into
dnnsoftware:develop
from
valadas:rm-root-folder-bug
Oct 23, 2022
Merged
Fixed an issue where resource manager would not have appropriate root folder #5351
david-poindexter
merged 4 commits into
dnnsoftware:develop
from
valadas:rm-root-folder-bug
Oct 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… folder Resolves an issue where in group/user/folder mode the folder list would always start at the site root instead of the folder dictated by the module settings. Closes dnnsoftware#4825
david-poindexter
approved these changes
Oct 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is FANTASTIC @valadas - thank you!!!
mitchelsellers
approved these changes
Oct 23, 2022
@valadas Looks like we have a build error |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Oct 23, 2022
In dnnsoftware#5351 a change was implemented to get the root folders according to the settings. Because of this a user is now always on some sort of root folder instead of the root folders not being part of any and having a virtual "root" ListItem. So before that change we were auto-expending that root item but now all direct children are open by default and it does not look right. This PR solves that by not expanding automatically the first level in the tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where in group/user/folder mode the folder list would always start at the site root instead of the folder dictated by the module settings.
Closes #4825
User mode:
Site Assets:
Global Assets:
Group mode:
Specific folder mode: