Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Next Button on install wizard #5368

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

uzmannazari
Copy link
Contributor

Summary

Modification of the next button in the get package information step, whose name could not be called from language resource files and could not be translated in multilingual portals.

Modification of the next button in the get package information step, whose name could not be called from language resource files and could not be translated in multilingual portals.
@mitchelsellers
Copy link
Contributor

Can we get more detail on this particular change? I don't see any addition to the resource files to then set this value, yet it was pulling from localization files already.

@uzmannazari
Copy link
Contributor Author

{Localization.get("Next.Button")} just added.
The element is already available in the language resource file

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, fiund it here

LGTM

@valadas
Copy link
Contributor

valadas commented Nov 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra information that this was already in the language pack

@mitchelsellers mitchelsellers added this to the 9.11.1 milestone Nov 3, 2022
@mitchelsellers mitchelsellers merged commit d551948 into dnnsoftware:develop Nov 3, 2022
@uzmannazari
Copy link
Contributor Author

Correct, fiund it here

LGTM

Thanks mr @valadas and @mitchelsellers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants