Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of whether in global assets mode #5414

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Nov 29, 2022

Summary

I haven't had a chance to test this, but I believe this should pass through to the API whether the module is in Global Assets mode or for the current portal.

@bdukes bdukes added this to the 9.11.1 milestone Nov 29, 2022
@bdukes bdukes requested a review from valadas November 29, 2022 21:00
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome!

@valadas
Copy link
Contributor

valadas commented Dec 4, 2022

It looks right but we have another problem (don't let this hold merging this PR as it's probably not caused by this)...
But we are now missing all the scripts in the module zip:
image

I'll try to figure out what happened with that the next weekend...

@valadas
Copy link
Contributor

valadas commented Dec 5, 2022

I'll try to figure out what happened with that the next weekend...

Hmm, I tried a build from develop and fixed some stuff on another PR and the files were there, nothing in this PR appears to possible be able to break that. @bdukes could you rebase on develop to see if the files are there with a new build that includes that fix...

@bdukes
Copy link
Contributor Author

bdukes commented Dec 5, 2022

I've rebased @valadas

@valadas
Copy link
Contributor

valadas commented Dec 5, 2022

Still missing:
image

WHY ?

@valadas
Copy link
Contributor

valadas commented Dec 5, 2022

It's unrelated to this PR though, I guess we may have an order of operations issue in the build or something cause it's like that on a CI build of the develop branch too. I'll merge this but we have to look into that at some point...

@valadas valadas merged commit 4e31a9f into dnnsoftware:develop Dec 5, 2022
@bdukes bdukes deleted the global-assets branch December 6, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants