Changed build to run all npm builds before backend builds. #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `yarn install` and `yarn build` before any project builds. It still uses lerna as before. - I confirmed that a failed install makes the build fail. - I confirmed that a failed npm build makes the build fail. - I confirmed that it fixed the resource manager scripts missing from the final build. The drawback of this approach is that one can no longer build only the persona bar in release mode without using cake. But for dev/debug, the current documented way with `yarn start --scope ...` is still valid.
david-poindexter
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Thank you @valadas - this looks like the lessor of evils here.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bdukes
reviewed
Dec 12, 2022
Comment on lines
+503
to
+505
| ProjectSection(ProjectDependencies) = postProject | ||
| {9CCA271F-CFAA-42A3-B577-7D5CBB38C646} = {9CCA271F-CFAA-42A3-B577-7D5CBB38C646} | ||
| EndProjectSection |
There was a problem hiding this comment.
Do we know what this change is?
There was a problem hiding this comment.
I have no clue, it was done by Visual Studio...
bdukes
reviewed
Dec 12, 2022
| @@ -1,14 +1,12 @@ | |||
| <Project ToolsVersion="4.0" DefaultTargets="Build" | |||
| xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="..\..\packages\Yarn.MSBuild.1.22.17\build\Yarn.MSBuild.props" Condition="Exists('..\..\packages\Yarn.MSBuild.1.22.17\build\Yarn.MSBuild.props')" /> | |||
| <Import Project="..\..\packages\Yarn.MSBuild.1.22.17\build\Yarn.MSBuild.targets" Condition="Exists('..\..\packages\Yarn.MSBuild.1.22.17\build\Yarn.MSBuild.targets')" /> | |||
There was a problem hiding this comment.
Should we remove the Yarn.MSBuild package entirely?
There was a problem hiding this comment.
Well, if we go with this solution then it is unused...
donker
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
yarn installandyarn buildbefore any project builds. It still uses lerna as before.The drawback of this approach is that one can no longer build only the persona bar in release mode without using cake. But for dev/debug, the current documented way with
yarn start --scope ...is still valid.